Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] arm64 build #9584

Merged
merged 7 commits into from
Mar 21, 2024
Merged

[chore] arm64 build #9584

merged 7 commits into from
Mar 21, 2024

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Feb 14, 2024

This PR adds a linux/arm64 build to the build of the collector, so it may support the goal of #9731

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (b34f535) to head (66627fc).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9584   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         353      353           
  Lines       18704    18704           
=======================================
  Hits        17026    17026           
  Misses       1350     1350           
  Partials      328      328           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atoulme atoulme force-pushed the actuated branch 2 times, most recently from 545acff to f5cb3e3 Compare February 15, 2024 22:12
@atoulme atoulme force-pushed the actuated branch 2 times, most recently from 4393d45 to f4e1430 Compare February 24, 2024 05:26
@atoulme atoulme marked this pull request as ready for review February 24, 2024 06:02
@atoulme atoulme requested review from a team and jpkrohling February 24, 2024 06:02
@atoulme atoulme changed the title [chore] try using actuated to build [chore] arm64 build Mar 8, 2024
mx-psi
mx-psi previously requested changes Mar 11, 2024
.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved
@mx-psi mx-psi dismissed their stale review March 12, 2024 09:27

Version was pinned

dmitryax pushed a commit that referenced this pull request Mar 19, 2024
Peeling this set of changes from #9584 as a separate PR.

These changes allow a reduction of issues when working with ARM64, which
seems to fail on some of the resource locking used in those tests.
@atoulme
Copy link
Contributor Author

atoulme commented Mar 20, 2024

@open-telemetry/collector-approvers anyone interested in reviewing this PR?

@dmitryax dmitryax merged commit 2037527 into open-telemetry:main Mar 21, 2024
49 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 21, 2024
codeboten pushed a commit that referenced this pull request Aug 2, 2024
These things were added for the [arm
build](#9584)
which has been moved to its own job.

Fixes
#10587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants